WhoHas

Line 934? That's just an "end" in my file. Line 814 in mine is:

vault[who][name] = (vault[who][name] or 0) + count;

What I should have done is replace lines 812-815 with the same thing as 790-803, minus the "[tab]" references. That was a really stupid oversight on my part.

Then again, what I really ought to do is find a better way to get the Armory data - the Guild Bank data changes shape at different times, and that's not good.

Anyway, glad it's finally working. I'll post *another* official fix soon.

OK, it should be fixed now. ArmoryGuildBank does some weird things now that were confusing WhoHas. Get the 3.3.1 version of WhoHas.

... it's "god", btw. ;)

This is the part of the code that deals with Armory Guild Bank. I bet its database format changed when Armory's did. I'll get a fix up shortly.

"Still"? Sorry, I didn't know it was doing this in the first place - I haven't seen any trouble myself. I'll take a look at it.

As far as I know, Armory didn't used to do this. WhoHas also works with Possessions and CharacterProfiler, neither of which do this themselves, and I can add support for other inventory addons, too. Unless it has changed, the basic Armory doesn't track your guild banks either, which WhoHas will do for you. Anyway, when I first wrote it, WhoHas was the only addon I know of that modified all item tooltips. Possessions did something similar, but only inside the Possessions window.

I'd say, if Armory is doing the same thing and suits your needs, stick with it. WhoHas won't add much for you in that case.

Here are some other things to consider. I can respect trying to keep your addon memory down - that's a pain. WhoHas tries to use as little memory as possible, and doesn't even track your inventory by itself. It gets all of its data from Armory or some other inventory addon. (Except for guild bank data, in some cases.)

Originally WhoHas used almost no memory, but that proved to be expensive in CPU time. Now it keeps a cache of inventory data in the format it needs so that it can redraw tooltips with very little CPU hit. Because Armory keeps its data in a much more detailed format, I don't know whether it is doing the same, or whether it behaves like WhoHas originally did. WhoHas' cache *does* use up some memory, but it's relatively little compared to something like Armory.

I don't take any offense at the question. I say, just use whatever works best for you!

I think there are several addons that do that now. The one I use is one of the (if not THE) oldest, Reagent Info. It's changed hands several times in its history, and the current maintainer hosts it here: http://ri.gametraveler.ch/

The problem with profession mats is that the game client doesn't give you that data directly. It will tell you what mats a recipe needs - if your char knows the recipe - but not the reverse. So you have to manually maintain a large database of recipes and the mats they use in the addon. I can tell you right out that if I did that in WhoHas, I would never manage to keep it up to date with any regularity - I'm just not that disciplined. Pelion (Reagent Info's maintainer) does a good job of it. The recipe info shows up in your tooltips just like the WhoHas info does, and I find it *very* useful.

FWIW, I liked Possessions too - it was very lightweight compared to Armory. It has also changed hands several times, and I agree it's not maintained anymore. Perhaps I'll think about picking it up.

Hmmm, can't edit your own comments anymore?

I meant to say, "I agree it's a shame that it's not maintained anymore."

@marblex

WhoHas doesn't store the data itself - it just gets it from whatever inventory addon you're using. Can I assume you're using Armory? If so, you can reset your data from chat.

To reset everybody, type:
/armory delete all

To reset one char, type:
/armory delete char NAME

To reset a whole realm, type:
/armory delete realm NAME

If you use one of the last two, then "NAME" has to be in the exact case. For instance, "marblex" will work, but "MarbleX" won't. You will have to login to each char you delete to repopulate their data. I'm not sure what the command is to reset the guild bank data. You can also type "/armory help" to get more command help.

If you're using Possessions or CharacterProfiler, then the easiest thing to do is delete their files (whichever one you have) from your SavedVariables. You will have to login to each of your characters to repopulate the data after that.