FuBar_MailExpiryFu

I'm getting an error. These add-ons are the latest version(auto updated from curse).

Please help

Date: 2009-11-30 16:41:33
ID: 1
Error occured in: Global
Count: 1
Message: ..\AddOns\FuBar_MailExpiryFu\MailExpiryFu.lua line 418:
attempt to perform arithmetic on field 'minDaysLeft' (a nil value)
Debug:
...uBar_MailExpiryFu\Libs\AceAddon-2.0\AceAddon-2.0.lua:25:
...uBar_MailExpiryFu\Libs\AceAddon-2.0\AceAddon-2.0.lua:23
...uBar_MailExpiryFu\Libs\AceAddon-2.0\AceAddon-2.0.lua:1055: ManualEnable()
...uBar_MailExpiryFu\Libs\AceAddon-2.0\AceAddon-2.0.lua:983:
...uBar_MailExpiryFu\Libs\AceAddon-2.0\AceAddon-2.0.lua:976
[C]: ?
...uBar_MailExpiryFu\Libs\AceEvent-2.0\AceEvent-2.0.lua:260: TriggerEvent()
...uBar_MailExpiryFu\Libs\AceEvent-2.0\AceEvent-2.0.lua:910:
...uBar_MailExpiryFu\Libs\AceEvent-2.0\AceEvent-2.0.lua:903
AddOns:
Swatter, v5.6.4424 (KangaII)
ACP, v3.2.0.23
FuBar, v
FuBarMailExpiryFu, v1.4.7
BlizRuntimeLib_enUS v3.2.2.30200 <us>
(ck=80)

I just got a reply saying to delete the Lua's for this add-on in the WTF folder. I did this and its fixed.

If that doesn't work you manually change the min days left from something other then 0 and it should auto fix itself from there too.

I often have more than 50 mails in my mailbox - 50 is the maximum, that wow ui will show.
So when I have mails saved in your log, that will expire in 2 days, and I have more than 50 mails 'above' this mail, so, it won't be shown in the mailbox ui from wow, will your addon update its data with the data it sees (only 50 mails) and erasing the rest (the mails, that will be deleted soon)? Or will it remind them and warn me when they will expire.

Hope you understood =)

Even with a clean install and a bare minimum addons (Fubar, Broker2Fubar, Bugsack and Buggrabber), this bombs with:

"FuBar_MailExpiryFu-1.4.4\MailExpiryFu.lua:21: AceAddon: AceOO-2.0: Library "FuBarPlugin-2.0" does not exist."

Upon looking, the FuBarPlugin-2.0.lua file is located in Libs\FuBarPlugin-2.0\FuBarPlugin-2.0 (an extra layer of nesting that none of the other embedded libraries use).

After moving that file up one level, the addon works fine. My question is, how does this work for anyone else?

Thanks much. That would explain why it used to work before I removed a bunch of addons.

Thanks crowbait - after clearing my saved variables your update works well for me.

Nice job, crowbait! This got me up and running again. The only thing that still seems broken is the case where mail is sent to a character who hasn't logged in since the addon has been installed. The sendmail hook and the SaveForAlt function assumes that the character being mailed to is already set up in the saved variables. This doesn't seem to occur until a char has logged in and accessed mail. Workaround is to make sure that after you install the addon, log into all your chars and have them check mail before sending stuff among your chars. This should ensure that the saved variables get set up correctly.

Let's hope the original author returns to address these issues!

Svurg

Probably more detail than anyone (except svurg?) wants below. First, my attempt at a fix. I make NO WARRANTIES of any sort, although I haven't done anything deliberately destructive. You can get it here:
http://my.curse.com/members/crowbait/files/MailExpiryFu.lua.patched_2D00_1.4.2.txt.aspx

You will probably have to remove your MailExpiryFu savedvariables -- a fix which wouldn't require this would be a lot more complicated (I suspect I would need to do some exception handling, and since i haven't even touched a LUA reference yet, I'm loathe to go there).

-- Do-It-Yourself Fix Changes --

The three changes which _appear_ to be working:
1) Around line 193, after line "self:Save()", remove line "self:OnUpdate()".
2) Around line 373, after line "self.savingMailboxData = false", add line "self:OnUpdate()".
3) Around line 457, after line "function MailExpiryFu:OnUpdate()", add 3 lines:
if self.savingMailboxData then
return
end

-- Details --

I just did a whole bunch of debugging (which is fun, since it's my first foray into LUA). In the end, this is what I think is happening:

In certain cases, on new characters, the Save function gets called. Inside that Save function, it does a ReIndex in order to fill in some data. This calls Save again -- but he's handled this case, and Save returns cleanly if it's in progress. However, the ReIndex then attempts to Update, which tries to sort the half-built data, and ends up erroring out. I don't know the LUA flow here, but it seems like it throws an exception which exits the function without marking Save as done.

Thus, the initial Save never completes. No further Saves can happen because it thinks it's still in the middle of a Save. And later calls to OnUpdate also fail, because the data is stuck in a half-formed setup, and is then actually written to SavedVariables in that incomplete, error-causing way.

How to fix? First, I added a check to OnUpdate to make sure it's not saving and return if it is. But then, perhaps an update is necessary after save. So as a hack, I just called OnUpdate from the end of Save. This makes the call to OnUpdate from ReIndex redundant, so I removed that. This _might_ make the save check in OnUpdate unnecessary, because it's not clear it is ever called during a Save from anyplace else. But I left it in to be safe.

I'm the first to admit I don't fully understand the flow of this program (or LUA), but hopefully this hack will keep it working until a real fix comes from the author. Thanks for a great addon!

-crowbait

Thanks a lot Crowbait, working perfectly now, brilliant

I did some checking...the problem appears to be that the data being written out in the saved variables is blank for some characters, so when the code tries to look up the minDaysLeft field of that data, it throws an exception.

The save() function contains the code that writes out the saved variable data. It is supposed to run on a tight loop, courtesy of it being registered with AceEvent:ScheduleRepeatedEvent, and also is supposed to be triggered on the MAIL_INBOX_UPDATE, MAIL_SHOW, and UPDATE_PENDING_MAIL events.

I inserted an AddMessage("save called") to the function so I could see when it was being called, and discovered that none of this was happening. I would have expected to see a stream of "save called" chat messages due to the tight loop -- saw none. I opened my mailbox, but no chat message either.

So it appears that for some reason the events aren't triggering the save() function. Unfortunately, I've about hit my limit of lua and WOW API understanding, so I have no clue as to how to fix it. My hope is that this message will give someone with more knowledge than I (perhaps even the author) a base to launch from.

Hope this gets fixed soon -- as an altaholic I find it _very_ useful! What would be really neat is if it could integrate with the new calendar function.

Svurg

Its not working for me at all since the last version. Please update...

FuBar_MailExpiryFu-1.4.2\MailExpiryFu.lua:415: attempt to perform arithmetic on field 'minDaysLeft' (a nil value)

Just got the same 'minDaysLeft' error. Logged out and deleted the FuBar_MailExpiryFu.lua file in \WTF\Account\\SavedVariables and it's working fine now (of course now need to repopulate the data from my alts...).

As far as it goes the only thing I did since logging off last night (where I'd had no errors) was deleting a character and rolling a death knight. /shrug

Had to disable the mod as the error keeps popping up even after purging the saved data. Svurg's comments appear particularly interesting, will try take a look into the code but don't think I'll have any better luck than he did as my knowledge of the underlying api is limited at best.

The calendar integration is an awesome!!! idea btw

/signed another hopeless altaholic

Me too. Plus, when I disabled the plugin via the right click menu, it still gave me the error. I had to log out and disable the plugin entirely.

1.4.2 was working fine until this morning when I logged into a new toon.

[2008/11/10 16:20:07-759-x2]: FuBar_MailExpiryFu-1.4.2\MailExpiryFu.lua:415: attempt to perform arithmetic on field 'minDaysLeft' (a nil value)
(tail call): ?:
: ?
FuBar_MailExpiryFu-1.4.2\MailExpiryFu.lua:465: in function `OnUpdate'
FuBar_MailExpiryFu-1.4.2\MailExpiryFu.lua:200: in function `OnTooltipUpdate'
FuBarPlugin-2.0-90003:393: in function `runChildren'
Tablet-2.0-90216 (TabletLib):2370: in function `children'
Tablet-2.0-90216 (TabletLib):2414: in function `Open'
Tablet-2.0-90216 (TabletLib):2548: in function
FuBarPlugin-2.0-90003:442: in function <...\FuBarPlugin-2.0\FuBarPlugin-2.0\FuBarPlugin-2.0.lua:441>