GridAutoFrameSize

thanks crazybenny. have you been able to reproduce this behavior? would it be helpful if i post a screenshot somehow?

Hi CrazyBenny, no it does not.

If I'm running Grid without this addon, and turn on Grid after entering a BG, I do not have the strange "overlapping" of grid frames. Instead it looks like normal Grid except that the background is unnecessarily large (if in a BG of less than 40 players), since it wasn't resized by this addon.

Hth.

Enabling Grid *after* already entering a battleground causes strange corruption and overlapping of grid frames.

Any ideas what might be causing this? Any ideas what a fix might be?

The problem does not happen if Grid was already enabled *before* entering the battleground.

Change line 12 in GridAutoFrameSize.lua

local GetCurrentDungeonDifficulty = GetCurrentDungeonDifficulty
into
local GetCurrentDungeonDifficulty = GetInstanceDifficulty

Until http://www.curseforge.com/projects/curse-client-new/tickets/140-localy-edited-addons-no-longer-show-when-an-update/ is fixed in the curse client, i prefer not to do local mods to addons.

Needs to be updated for 3.2:

[2009/08/05 20:39:36-943-x221]: GridAutoFrameSize-2.3.5\GridAutoFrameSize.lua:49: attempt to call upvalue 'GetCurrentDungeonDifficulty' (a nil value)

---

Thanks for the fast fix.ill give it a try today.

I did a bunch of testing just now with Wintergrasp and a raid I was given an assist in (at the end several people logged while still in it so I was able to mess around).

What I observed:
1) I was in a non-heroic raid group with the setting as "By Group 10."
2) Auto Resizing worked up to 25 but no further despite the raid growing all the way up to between 27-31 people before I manually switched it.
3) Manually switching to "By Group 40" worked.
4) Auto Resizing only works on 5, 10, 15, 25, and 40.
5) Auto Resizing does not work for 20, 30, and 35. (What that means: A raid with 16-20 people will have a frame sized 25. A raid with 26-30 or 31-35 players will have a frame sized 40.)

I think I've figured what to do to make this work best for what I'm wanting:
1) Heroic Raid, Raid, and Battleground should be set to "By Group 40" and they properly resize themselves.
2) Auto Size Raid Frame and Always use pet layouts should be checked.
3) Party (and I assume Arena) layouts set to "By Group 5" are still not updating to hide the pet frame if pets are gone because it's not forcing a refresh (can't move people groups and then summon/dismiss pets like in raids).
4) If I choose "By Group 5" for Solo I don't get a pet frame, but do with "By Group 5 w/pets" but have the same issue of it not updating to hide it when the pet is gone.


I hope this is clear! Spent an hour messing around with settings so I have tons of notes and screenshots, but I think I got it all. XD

With the above settings I went into a WG just now and once it got to 26 people Swatter caught this:
Date: 2009-03-03 14:58:18
ID: 2
Error occured in: Global
Count: 1
Message: ...ce\AddOns\Aloft\Libs\AceLocale-2.2\AceLocale-2.2.lua line 487:
AceLocale(Grid): Translation "By Group 40 w/Pets" does not exist.
Debug:
...ce\AddOns\Aloft\Libs\AceLocale-2.2\AceLocale-2.2.lua:488:
...ce\AddOns\Aloft\Libs\AceLocale-2.2\AceLocale-2.2.lua:485
...ce\AddOns\Aloft\Libs\AceLocale-2.2\AceLocale-2.2.lua:46:
...ce\AddOns\Aloft\Libs\AceLocale-2.2\AceLocale-2.2.lua:44
...rface\AddOns\GridAutoFrameSize\GridAutoFrameSize.lua:81:
...rface\AddOns\GridAutoFrameSize\GridAutoFrameSize.lua:76
...rface\AddOns\GridAutoFrameSize\GridAutoFrameSize.lua:220: ?()
...face\AddOns\Aloft\Libs\AceEvent-2.0\AceEvent-2.0.lua:695:
...face\AddOns\Aloft\Libs\AceEvent-2.0\AceEvent-2.0.lua:682
[C]: ?
...face\AddOns\Aloft\Libs\AceEvent-2.0\AceEvent-2.0.lua:368:
...face\AddOns\Aloft\Libs\AceEvent-2.0\AceEvent-2.0.lua:345

It's not working correctly for the basic Raid set-up. Heroic it's fine I think, can't check at the moment, but I didn't notice anything funky last night.

I get this error when I try to change it manually while in the raid to try and fix what layout I have it set to (going from 40 man to 10 man with pets):
Date: 2009-02-25 13:34:32
ID: 2
Error occured in: Global
Count: 3
Message: LibRockConfig-1.0: Field "desc" not found for `Grid->GridAutoFrameSize'.
Debug:
...s\FuBar\libs\LibRockConfig-1.0\LibRockConfig-1.0.lua:1849:
...s\FuBar\libs\LibRockConfig-1.0\LibRockConfig-1.0.lua:1650
...s\FuBar\libs\LibRockConfig-1.0\LibRockConfig-1.0.lua:3575:
...s\FuBar\libs\LibRockConfig-1.0\LibRockConfig-1.0.lua:3566


When someone new then joins the group it fixes itself, updating the layout.

Your addon is great, but I have a request:
Have it automatically resize based on whether a pet is active or not (with an option to enable/disable this). Something like:

local function getWithPetsLayout(layout)
if PetHasActionBar() then
return layout.." w/Pets"
end
if not GridAutoFrameSize.db.profile.withPets then
return layout
end

return layout.." w/Pets"
end
Which only works when the frame is updated through Grid calling the "Grid_RosterUpdated" event (which doesn't seem to happen when a pet is called/dismissed). I would add the event myself, but I'm new to lua, and am not sure how Grid carries it's current layout.

Thanks!