DiamondThreatMeter

I've uploaded a "fix" for this on wowinterface for those of you not keen to updating lua.

http://www.wowinterface.com/downloads/info15386-DiamondThreatMeter3.3Updatedfixed.html

really great work Velhenn !!! works fine now... but the threat show on top of the mobs health bar isnt still working, but was working fine before the patch.....any ideas to fix that ?

Here is the bug :
"The deprecated GetFrameType method has been completely removed (GetObjectType offers the same result)"

You can fix it by openning the file called "CoolNameplateLib.lua" in
- <WoWroot>/Interface/AddOns/DiamondThreatMeter/common/
Then go to line 66 or search this word "GetFrameType", and change it to "GetObjectType".

Repeat this with the "configPanelTemplates.lua" file in
- <WoWroot>/Interface/AddOns/DiamondThreatMeter/gui/options/
Go to line 88, you should find a "GetFrameType" function again... so replace it.

It should work again then.

Worked for me also. Thanks a bunch for the help :)

That's it? Great! Thanks!

fantastic.. I will make the changes tonight.. Really appreciate it..

I sure hope someone will make this usable in 3.3 as it is the only threat meter I enjoy using..

Right now the old version makes my FPS drop from 60ish to 11.. can someone please attempt to updated it.. that would rock!!!

Thanks in advance..

It seems completely broke now in 3.3. Author hasn't responded to any previous requests, so it seems to be truly R.I.P. now for this great addon. I might try another self-help fix myself sooner or later, but judging from the overload of errors I got logging on today it seems too broke for quick fixing.

Is there a way to configure the addon, move the frames etc while not in combat please. I cant for the life of me see that option, if, indeed, it even exists. Thanks in advance & great work on a fine Mod, keep up the good work :)

I think I may take up actually redoing the addon in my spare time since it wont be updated again anytime soon. In the mean time I have created a quick bug fix version here: [URL]http://dl.getdropbox.com/u/353710/WoW%20Stuff/DTM/index.htm[/URL]

That address is static, so check it periodically for updates. If enough interest is in it I'll add it to WowI and Curse

You might want to do that. People will probably not trust it being hosted on an external server. A list of what bugs were fixed would also be useful.

For those interested. I'm quite sure I've found the problem with the SAP CC. In the crowdControl.lua there are only 3 ranks of Sap defined. The 4th rank (lv 71, 60 seconds duration) is missing. I've added it to the file and tested it. Uptill now I haven't gotten the error anymore.

I will try to find a way to place the fix here, but it's easy to fix yourself with a texteditor like notepad.

In the addonfolder goto the DiamondThreatMeter\engine\ folder, and open crowdControl.lua

On line 123 you'll find SAP section. Make it look like this:

["SAP"] = {
ignoreGlobalThreat = 1,
notSpammable = nil,
duration = {
[1] = 25,
[2] = 35,
[3] = 45,
[4] = 60,
},
},

Note the element with [4], that needs to be added. After that, it should run smoothly again.

I'll also try to find the location where it throws the huge in-your-face error, which is of interest to nobody, and try to find a way to disable it. That should make it safe to use again.

Wow. If that's all it was I am thoroughly annoyed. What an easy thing for the author to fix, and I'm surprised he didn't think of it with his "everything's fine again" 3.2 release. I have made the change you suggested, and it makes perfect sense that it would have been the culprit.

Sap is the only CC ability I've noticed that causes this problem, but now that you've got me curious, I'm going to try to think of and review ranks of other CC methods to make sure they couldn't potentially be problematic as well.

Ifyou find a way to completely hide that error screen, that would be amazing as well. Thanks again for finding this :)

Here's what I found. For those that prefer not to read, there are several errors that will cause incorrectly reported threat, but rogue sap should be the only change needed to prevent the error screen of death. It's possible that polymorph black cat would cause the problem without my change below, too.

For those wishing to clean things up, find the areas in the documents with these headers in brackets, and change the sections to match what I'm posting here:

["WYVERN_STING"] = {
ignoreGlobalThreat = 1,
notSpammable = nil, -- Hardly/unlikely but still technically possible to refresh it.
duration = 30, -- Duration was 12, should've been 30
},

-- Add this entire section below POLYMORPH_TURTLE. Black cat wasn't added as a threat wipe at all:
["POLYMORPH_BLACK_CAT"] = {
ignoreGlobalThreat = 1,
notSpammable = nil,
duration = 50,
},

-- Remove this section. There's no such thing as turn undead anymore.
["TURN_UNDEAD"] = {
ignoreGlobalThreat = 1,
notSpammable = nil, -- Hardly/unlikely but still technically possible to refresh it.
duration = {
[1] = 10,
[2] = 15,
},
},

Also as an FYI, if you are glyphed to make psychic scream last 10 seconds, it will only cause a threat wipe for 8. I don't know of a way around this.

Granted I don't understand a lot about WoW API - maybe the black cat addition needs to actually be reference somewhere to do something. I'd be interested to see if I can find someone with the ability to find out if it causes problems or not.

abilities.lua
DTM_Abilities["POLYMORPH_BLACK_CAT"] = DTM_Abilities["POLYMORPH"];

And internals.lua has several references. It helps if you spoeak French and German for those sections though.

It seems like most of the application is still living in TBC days. It also lacks the paladins repentance as CC for example and if you look at files like the npcAbilities.lua you'll see that it only contains TBC bosses. I'm pretty sure there's bosses with threataltering abilities in LK too, like the spores on loatheb for example.

I feel like fixing everything, but my lua knowledge is almost non-existant, and so is my time. I think I'm going to be happy with the sap fix and ignore the rest. I just hope MrCool one day decides to return to this great addon and updates it completely.

But for now, I've found a fix for the error popup:

Go to the /gui/errorConsole.lua file and remove line 214 (or put 2 minus signs in front of it).

I haven't tested this very well (that requires me to force errors some way), but it's so obvious the place where the window get's opened I don't think I need to.

Hey im new to usingg this and really like it especially the regain list as i can see in blue which enemy i dont afe aggor on but it would be really nice if there was some way i could clik that name and it automatically switch my target is this efen possibe or can u lardy do it and its not an option i dont know how to use PLEEEEESE help im desperate that would make this the best threat metr in the world

That was barely english. That aside, the answer is still no.

I have found out the same, I still got a lot of crowdcontrol lua errors on my screen ..Which will force me back to omen for now... again :(

As an FYI, this doesn't "work fine with 3.2". CC abilities like Sap still cause the error screen to pop up midpull.