CustomButtons

A big thank you for a wonderful and useful addon.

Two questions:
Is there a way to make global cooldowns show on the buttons and if there is a /castsequence or conditional modifier macro bound to buttons, can the buttons be ade to show the spell being cast?

it would be nice if mounts and vanity pets could be added to these buttons then i could scale them small so they wouldnt take up too much space

Please please, work on keybindings first. This mod would be perfect for how I play, but I just need keybindings. <3

Is there any way to add a key binding to the new buttons?

hello.
Useful addon thx.

have taint error. plz fix this error.
Have a nice day~!
------
An action was blocked in combat because of taint from CustomButtons - CustomButtonsButton6:Show()Interface\AddOns\CustomButtons\CustomButtons.lua:434 CustomButtons_UpdateUsable()
Interface\AddOns\CustomButtons\CustomButtons.lua:363 CustomButtons_OnUpdate()
CustomButtonsButton6:OnUpdate()
An action was blocked in combat because of taint from CustomButtons - CustomButtonsButton7:Show()
Interface\AddOns\CustomButtons\CustomButtons.lua:434 CustomButtons_UpdateUsable()
Interface\AddOns\CustomButtons\CustomButtons.lua:363 CustomButtons_OnUpdate()
CustomButtonsButton7:OnUpdate()
An action was blocked in combat because of taint from CustomButtons - CustomButtonsButton8:Show()
Interface\AddOns\CustomButtons\CustomButtons.lua:434 CustomButtons_UpdateUsable()
Interface\AddOns\CustomButtons\CustomButtons.lua:363 CustomButtons_OnUpdate()
CustomButtonsButton8:OnUpdate()
An action was blocked in combat because of taint from CustomButtons - CustomButtonsButton4:Show()
Interface\AddOns\CustomButtons\CustomButtons.lua:434 CustomButtons_UpdateUsable()
Interface\AddOns\CustomButtons\CustomButtons.lua:363 CustomButtons_OnUpdate()
CustomButtonsButton4:OnUpdate()
An action was blocked in combat because of taint from CustomButtons - CustomButtonsButton6:Show()

I'm weak at English. sorry.

this error on version 1.22
wtf delete => retry test => error

---- baud error frame message ----
CustomButtons blocked from using CustomButtonsButton2:Show()
Count: 99

Call Stack:
[C]: in function `Show'
Interface\AddOns\CustomButtons\CustomButtons.lua:434: in function `CustomButtons_UpdateUsable'
Interface\AddOns\CustomButtons\CustomButtons.lua:363: in function `CustomButtons_OnUpdate'
[string "*:OnUpdate"]:1: in function <[string "*:OnUpdate"]:1>

Have a nide day~!

I am using this to put a small shield slam and revenge icon in the middle of the screen so I know when they are ready to be used (not on cooldown) without looking all the way down to the action bars. It works pretty well, but I think it would look better if the buttons didnt have the border around them. Is there any way to add an option to turn off the borders?

Ideally the buttons would also disappear when the ability can't be used (due to cooldown or not enough rage), but thats probably too much to ask :P

Hi! Exactly what Im looking 4 all the time!!
Testet a little around with it an I have to say very nice...
Im using bartender4 to container makros on the left side of my screen to show how much emblems i got already...

like this:

#show Emblem des Frosts

in bartender4 it shows me the count of it, but when im using ur empty buttons, nothing is displayed... no tooltip and no count...

would be very nice if this could be fixed :)

Best wishes...

Floddy (EU-Tirion)

There are a few changes you could make in your _UpdateUsable() method that may help with this. You are missing macro text, consumable spell counts (spells that need reagents), and consumable item counts (charges remaining).

local counttext = _G[self:GetName().."Count"];

-- For Macros
local name, iconTexture, body = GetMacroInfo(macro);
counttext:SetText(name);

-- For Spells
if (IsConsumableSpell(spell)) then
local spellCount = GetSpellCount(spell);
if ( isUsable ) and (spellCount == 0) then
-- Some glyph or talent must have changed this to non-consumable spell
counttext:SetText("");
else
counttext:SetText(spellCount);
end
else
counttext:SetText("");
end

-- For consumable items, use the 3 parameter GetItemCount
local count = GetItemCount(item, nil, true);
if (IsConsumableItem(item)) then
counttext:SetText(count);
else
counttext:SetText("");
end

I'm borrowing a portion of your addon for my addon (which I will not shamefully plug)... So let me help you out with some improvements I've made... Not a very good messaging system here so, I'll do one a post...

-- Your code caused a never ending loop resulting in an LUA error sometimes
function CustomButtons_FindSpellId(spellname, spellrank)
local _, _, _, numSpells = GetSpellTabInfo(BOOKTYPE_SPELL);
for i=1, numSpells do
local spell, rank = GetSpellName(i, BOOKTYPE_SPELL);
if (spell) and (spellname == spell) then
if ((spellrank) and (spellrank == rank)) or (not spellrank) then
return i;
end
end
end
return nil;
end

Correction to the code in the original post...
function CustomButtons_FindSpellId(spellname, spellrank)
local spellCount = 0
for i = 1, MAX_SKILLLINE_TABS do
local name, texture, offset, numSpells = GetSpellTabInfo(i);
if not name then
break;
end
spellCount = spellCount + numSpells;
end
for i=1, spellCount do
local spell, rank = GetSpellName(i, BOOKTYPE_SPELL);
if (spell) and (spellname == spell) then
if ((spellrank) and (spellrank == rank)) or (not spellrank) then
return i;
end
end
end
return nil;
end

Note: my code may look a little different because I do not use that global variable for the "selected button".

-- And your item code in CustomButtons_UpdateUsable
local count = GetItemCount(item);
local name, _, _, _, _, _, _, itemStackCount = GetItemInfo(item);

if (count == 0) then
normalTexture:SetVertexColor(0.3, 0.3, 0.3);
pushedTexture:SetVertexColor(0.3, 0.3, 0.3);
else
normalTexture:SetVertexColor(1.0, 1.0, 1.0);
pushedTexture:SetVertexColor(1.0, 1.0, 1.0);
end

local counttext = _G[self:GetName().."Count"];

if (CustomButtonsConfig.ShowCount == 0 or count == 0 or (itemStackCount == 1)) then
counttext:SetText("");
else
counttext:SetText(count);
end
end

Your item tooltips kinda suck, try this code out...

local count = GetItemCount(item);
local itemName, itemLink = GetItemInfo(item);

-- Look for inventory item that have a "use", update the itemLink if found
InventorySlotNames = { "HeadSlot", "NeckSlot", "ShoulderSlot",
"BackSlot", "ChestSlot", "ShirtSlot", "TabardSlot", "WristSlot",
"HandsSlot", "WaistSlot", "LegsSlot", "FeetSlot", "Finger0Slot",
"Finger1Slot", "Trinket0Slot", "Trinket1Slot", "MainHandSlot",
"SecondaryHandSlot", "RangedSlot", "AmmoSlot" };

for index, slotName in pairs(InventorySlotNames) do
local slotId, textureName = GetInventorySlotInfo(slotName);
local itemLinkCheck = GetInventoryItemLink("player", slotId)
if (itemName and itemLinkCheck) then
local found = string.find(itemLinkCheck, itemName);
if (found) then
itemLink = itemLinkCheck;
end
end
end

GameTooltip_SetDefaultAnchor(GameTooltip, button);

if (itemLink) then
GameTooltip:SetHyperlink(itemLink);
end

A problem:

/cb is a reserved command now, it means CampoBatalla (batleground) so it acant be user anymore in spanish locales